Document that negative pids aren't UB, but may cause unexpected behavior.#1443
Merged
Conversation
…ior. As discussed in #1433, allow `Pid` values to be negative without invoking UB, because they can occur on systems configured with seccomp-bpf to make syscalls like `getpid` fail. However, also document that while this doesn't invoke UB, it isn't useful.
sunfishcode
added a commit
that referenced
this pull request
Apr 30, 2025
Fix a regression from #1443 which disallowed calling `Pid::from_raw` with the value 0.
sunfishcode
added a commit
that referenced
this pull request
Apr 30, 2025
Fix a regression from #1443 which disallowed calling `Pid::from_raw` with the value 0.
sunfishcode
added a commit
that referenced
this pull request
Apr 30, 2025
Fix a regression from #1443 which disallowed calling `Pid::from_raw` with the value 0.
sunfishcode
added a commit
that referenced
this pull request
Apr 30, 2025
* Fix the assertion in `Pid::from_raw` to accept 0. Fix a regression from #1443 which disallowed calling `Pid::from_raw` with the value 0. * Disable transmutes warnings for now. * Add a test. * Update CI to ubuntu-22.04, as ubuntu-20.04 is no longer supported. * Fix the build on Rust 1.63. * Temporarily work around nightly build errors on powerpc64-ibm-aix.
sunfishcode
added a commit
that referenced
this pull request
Apr 30, 2025
* Fix the assertion in `Pid::from_raw` to accept 0. Fix a regression from #1443 which disallowed calling `Pid::from_raw` with the value 0. * Disable transmutes warnings for now. * Add a test. * Update CI to ubuntu-22.04, as ubuntu-20.04 is no longer supported. * Fix the build on Rust 1.63. * Temporarily work around nightly build errors on powerpc64-ibm-aix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #1433, allow
Pidvalues to be negative without invoking UB, because they can occur on systems configured with seccomp-bpf to make syscalls likegetpidfail. However, also document that while this doesn't invoke UB, it isn't useful.